Fix UniqBeforePluck cop #135
Conversation
santib
force-pushed
the
fix-uniq-before-pluck
branch
2 times, most recently
from
fdaa312
to
c727652
Compare
|
@santib Sorry for the late reply.
First of all, I think that the current implementation is good to prevent the error.
Yeah, certainly breaking change is not desirable. It's a bit weird, but let's keep the cop name as Can you rebase with the latest master branch and add the changelog entry? |
santib
force-pushed
the
fix-uniq-before-pluck
branch
2 times, most recently
from
6bbf863
to
81ce30d
Compare
|
@koic updated. I put it in the "bug fixes" section since it could be considered a bug for newer versions of rails, but let me know if you want to change that or something else |
santib
force-pushed
the
fix-uniq-before-pluck
branch
from
81ce30d
to
2321b87
Compare
|
@santib Thank you for the updating. Can you add |
santib
force-pushed
the
fix-uniq-before-pluck
branch
2 times, most recently
from
0d01153
to
012f2e6
Compare
|
@koic done :) |
legacy-docs/cops_rails.md
Outdated
|
|
||
| # good | ||
| Model.uniq.pluck(:id) | ||
| Model.distinct.pluck(:id) |
There was a problem hiding this comment.
The document has been changed from Markdown (legacy-docs/cops_rails.md) to AsciiDoc (docs/modules/ROOT/pages/cops_rails.adoc). So, this Markdown document is not maintained.
Can you revert this Markdown doc?
There was a problem hiding this comment.
oops, not sure how this doc got updated 🤔
santib
force-pushed
the
fix-uniq-before-pluck
branch
from
012f2e6
to
8460d92
Compare
|
Nicely done, Thank you! |
Follow up rubocop#135. `Model.pluck(:id).distinct` happens the following `NoMethodError`. ``` NoMethodError: undefined method `distinct' for [42]:Array ``` This PR replaces it with `Array#uniq`.
Resolves #91
Notes:
uniqfordistinctor if it's fine to convertModel.pluck(:id).uniqtoModel.distinct.pluck(:id)within this cop.DistinctBeforePluckor not, since that would be a breaking change.